Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pylibftdi: init at 0.18.1 #71286

Merged
merged 1 commit into from Apr 28, 2020
Merged

pylibftdi: init at 0.18.1 #71286

merged 1 commit into from Apr 28, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Oct 17, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthuszagh
Copy link
Contributor Author

@jonringer I've squashed the commits as well.

@matthuszagh
Copy link
Contributor Author

Changes made. Let me know if that's what you had in mind for the search paths patch. Otherwise just waiting to hear back from upstream.

@matthuszagh matthuszagh force-pushed the pylibftdi branch 2 times, most recently from b52fae3 to 72bdd9e Compare April 28, 2020 03:15
@matthuszagh
Copy link
Contributor Author

@veprbl I've made all changes. Let me know if anything else/any issues. Thanks!

@matthuszagh
Copy link
Contributor Author

@veprbl done.

@veprbl
Copy link
Member

veprbl commented Apr 28, 2020

This doesn't work either:

[nix-shell:~/.cache/nix-review/pr-71286-1]$ python3Python 3.7.7 (default, Mar 10 2020, 06:34:06) 
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pylibftdi; pylibftdi.SerialDevice()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nix/store/95qjfhn4xbgpkr555qdcpmhrkba6mr0h-python3.8-pylibftdi-0.18.1/lib/python3.8/site-packages/pylibftdi/device.py", line 161, in __init__
    self.fdll = self.driver.fdll
  File "/nix/store/95qjfhn4xbgpkr555qdcpmhrkba6mr0h-python3.8-pylibftdi-0.18.1/lib/python3.8/site-packages/pylibftdi/driver.py", line 154, in fdll
    self._fdll = self._load_library('/nix/store/9h4143w27chfmidc42rz0m1rm9dslr35-libftdi1-1.4/lib/libftdi1.so')
  File "/nix/store/95qjfhn4xbgpkr555qdcpmhrkba6mr0h-python3.8-pylibftdi-0.18.1/lib/python3.8/site-packages/pylibftdi/driver.py", line 120, in _load_library
    name, search_list))
pylibftdi._base.LibraryMissingError: /nix/store/9h4143w27chfmidc42rz0m1rm9dslr35-libftdi1-1.4/lib/libftdi1.so library not found (search: ())

Maybe should be cdll.LoadLibrary instead.

@matthuszagh
Copy link
Contributor Author

cdll.LoadLibrary appears to work. At least I don't get a missing library error.

@veprbl veprbl changed the title pylibftdi: init at 0.17.0 pylibftdi: init at 0.18.1 Apr 28, 2020
@veprbl
Copy link
Member

veprbl commented Apr 28, 2020

@GrahamcOfBorg build python37Packages.pylibftdi python38Packages.pylibftdi

@veprbl veprbl merged commit 92212a5 into NixOS:master Apr 28, 2020
@matthuszagh matthuszagh deleted the pylibftdi branch April 28, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@veprbl veprbl veprbl approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthuszagh @veprbl @jonringer