Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] bepasty: add setuptools #71218

Merged
merged 1 commit into from Oct 17, 2019
Merged

[19.09] bepasty: add setuptools #71218

merged 1 commit into from Oct 17, 2019

Conversation

Lassulus
Copy link
Member

(cherry picked from commit 5e73d19)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Lassulus
bepasty: add setuptools
33fca06 
(cherry picked from commit 5e73d19)
@Lassulus Lassulus changed the title bepasty: add setuptools [19.09] bepasty: add setuptools Oct 16, 2019
@ofborg ofborg bot requested a review from makefu October 16, 2019 08:03
@acairncross
Copy link
Contributor

Would it not be sufficient for setuptools to go in buildInputs (as opposed to propagatedBuildInputs)?

@acairncross
Copy link
Contributor

Ah, I see that needing setuptools at build time isn't the problem. What actual problem is there? Running bin/bepasty-server seems to give me the same results with or without this patch (I get an error from Python AttributeError: 'NoneType' object has no attribute 'loader', but the server still seems to start up ok, in both cases).

@Lassulus
Copy link
Member Author

Lassulus commented Oct 16, 2019 •
edited

If I enable the service I get this error during startup

Oct 16 14:03:19 prism systemd[1]: Started Bepasty Server paste.krebsco.de.
Oct 16 14:03:19 prism gunicorn[1317]: Traceback (most recent call last):
Oct 16 14:03:19 prism gunicorn[1317]:   File "/nix/store/yqfr2j1ajcknvmxsbnvk93mas2764832-python2.7-gunicorn-19.9.0/bin/.gunicorn-wrapped", line 7, in <module>
Oct 16 14:03:19 prism gunicorn[1317]:     from gunicorn.app.wsgiapp import run
Oct 16 14:03:19 prism gunicorn[1317]:   File "/nix/store/yqfr2j1ajcknvmxsbnvk93mas2764832-python2.7-gunicorn-19.9.0/lib/python2.7/site-packages/gunicorn/app/wsgiapp.py", line 9, in <modul>
Oct 16 14:03:19 prism gunicorn[1317]:     from gunicorn.app.base import Application
Oct 16 14:03:19 prism gunicorn[1317]:   File "/nix/store/yqfr2j1ajcknvmxsbnvk93mas2764832-python2.7-gunicorn-19.9.0/lib/python2.7/site-packages/gunicorn/app/base.py", line 12, in <module>
Oct 16 14:03:19 prism gunicorn[1317]:     from gunicorn import util
Oct 16 14:03:19 prism gunicorn[1317]:   File "/nix/store/yqfr2j1ajcknvmxsbnvk93mas2764832-python2.7-gunicorn-19.9.0/lib/python2.7/site-packages/gunicorn/util.py", line 12, in <module>
Oct 16 14:03:19 prism gunicorn[1317]:     import pkg_resources
Oct 16 14:03:19 prism gunicorn[1317]: ImportError: No module named pkg_resources
Oct 16 14:03:19 prism systemd[1]: bepasty-server-paste.krebsco.de.service: Main process exited, code=exited, status=1/FAILURE

also putting it in buildInputs yields the same result

also happening with python3

Oct 16 14:29:13 prism systemd[1]: Started Bepasty Server paste.krebsco.de.
Oct 16 14:29:13 prism gunicorn[27850]: Traceback (most recent call last):
Oct 16 14:29:13 prism gunicorn[27850]:   File "/nix/store/zg8xn39hkinhb4k7xqn4k9rix6s9rapn-python3.7-gunicorn-19.9.0/bin/.gunicorn-wrapped", line 7, in <module>
Oct 16 14:29:13 prism gunicorn[27850]:     from gunicorn.app.wsgiapp import run
Oct 16 14:29:13 prism gunicorn[27850]:   File "/nix/store/zg8xn39hkinhb4k7xqn4k9rix6s9rapn-python3.7-gunicorn-19.9.0/lib/python3.7/site-packages/gunicorn/app/wsgiapp.py", line 9, in <module>
Oct 16 14:29:13 prism gunicorn[27850]:     from gunicorn.app.base import Application
Oct 16 14:29:13 prism gunicorn[27850]:   File "/nix/store/zg8xn39hkinhb4k7xqn4k9rix6s9rapn-python3.7-gunicorn-19.9.0/lib/python3.7/site-packages/gunicorn/app/base.py", line 12, in <module>
Oct 16 14:29:13 prism gunicorn[27850]:     from gunicorn import util
Oct 16 14:29:13 prism gunicorn[27850]:   File "/nix/store/zg8xn39hkinhb4k7xqn4k9rix6s9rapn-python3.7-gunicorn-19.9.0/lib/python3.7/site-packages/gunicorn/util.py", line 12, in <module>
Oct 16 14:29:13 prism gunicorn[27850]:     import pkg_resources
Oct 16 14:29:13 prism gunicorn[27850]: ModuleNotFoundError: No module named 'pkg_resources'
Oct 16 14:29:13 prism systemd[1]: bepasty-server-paste.krebsco.de.service: Main process exited, code=exited, status=1/FAILURE

@acairncross
Copy link
Contributor

I see, thanks for the clarification!

@Lassulus Lassulus merged commit 15e2aed into NixOS:release-19.09 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lassulus @acairncross