Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager-fortisslvpn: create the local state directory #71298

Merged
merged 1 commit into from
Oct 18, 2019
Merged

networkmanager-fortisslvpn: create the local state directory #71298

merged 1 commit into from
Oct 18, 2019
+6 −1

Conversation

symphorien
Copy link
Member

Otherwise connecting simply fails:
VPN connection: failed to connect: 'La création du fichier « /tmp/lib/NetworkManager-fortisslvpn/0507e3ef-f0e0-4153-af64-b3d9a025877c.config.XSB19Z » a échoué : No such file or directory'

Currently the plugin is non-functional so I think a backport to 19.09 is required.

Things done

Tested by connecting to a vpn.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 17, 2019
@ofborg ofborg bot requested review from obadz, Phreedom and domenkozar October 17, 2019 22:00
@worldofpeace
Copy link
Contributor

I wonder if other plugins need setup for a state directory.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 17, 2019
@symphorien
Copy link
Member Author

I know that openvpn and iodine don't. (iodine is slightly broken but not for this reason, I should bump it to master as the master branch contains fixes)

@symphorien
Copy link
Member Author

Hum I don't know what the ofborg failures mean.

@worldofpeace
Copy link
Contributor

Me either @symphorien, the checks have been having weird failures all the time this week (all seemingly unrelated).

@worldofpeace
Copy link
Contributor

@symphorien I asked @grahamc about it. I've been seeing stuff like this with a high frequency this week.

@grahamc
Copy link
Member

grahamc commented Oct 17, 2019

It seems nixpkgs can't be fully evaluated in 16gb anymore. I can't address this tonight, but will put it on my to-do for tomorrow morning.

@grahamc
Copy link
Member

grahamc commented Oct 17, 2019

@GrahamcOfBorg eval

I took an expensive route to try and fix it for the night

@flokli flokli mentioned this pull request Oct 18, 2019
Merged
10 tasks
worldofpeace
worldofpeace suggested changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of #71322 we can't merge the commit to master.
Though it you make the pkgs/tools/networking/network-manager/fortisslvpn/default.nix its own commit and add tmpfile rules for master that should work.

And backport changes to pkgs/tools/networking/network-manager/fortisslvpn/default.nix and add the stateDirs separate.

@symphorien
Copy link
Member Author

symphorien commented Oct 18, 2019 •
edited
Loading

Fixed merge conflict.

That would have been nice of @flokli to wait for this PR to be merged. It would have saved me a great deal of work and compilation on top of master.

@symphorien symphorien mentioned this pull request Oct 18, 2019
Merged
@symphorien
Copy link
Member Author

I opened a backport PR at #71366

@symphorien @worldofpeace
networkmanager-fortisslvpn: create the local state directory
a37b963 
Otherwise connecting simply fails:
VPN connection: failed to connect: 'La création du fichier « /tmp/lib/NetworkManager-fortisslvpn/0507e3ef-f0e0-4153-af64-b3d9a025877c.config.XSB19Z » a échoué : No such file or directory'
@worldofpeace worldofpeace changed the title nm-fortisslvpn: create the local state directory networkmanager-fortisslvpn: create the local state directory Oct 18, 2019
@worldofpeace worldofpeace merged commit 1554e4a into NixOS:master Oct 18, 2019
@worldofpeace
Copy link
Contributor

Thanks for doing this @symphorien. And yes, it was unfortunate for such a conflict to occur.

@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 18, 2019
@flokli
Copy link
Contributor

flokli commented Oct 20, 2019

@symphorien sorry for causing you trouble, I indeed should have waited for this PR to be merged in first.

@symphorien symphorien deleted the nm-fortissl branch March 21, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@obadz obadz

@Phreedom Phreedom

@domenkozar domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@symphorien @worldofpeace @grahamc @flokli