Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk-doc: fix on darwin #71299

Merged
merged 1 commit into from Oct 18, 2019
Merged

gtk-doc: fix on darwin #71299

merged 1 commit into from Oct 18, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

See #71221 (comment)

Things done

Built glib on darwin and linux.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 17, 2019
@worldofpeace worldofpeace mentioned this pull request Oct 17, 2019
Closed
10 tasks
@ofborg ofborg bot requested a review from pSub October 17, 2019 22:12
@hedning
Copy link
Contributor

hedning commented Oct 18, 2019

Lets get this in before staging-next starts building again (eta: UTC: 10.18 21:50).

@FRidh
Copy link
Member

FRidh commented Oct 18, 2019

could you put the actual explanation in the commit message

@worldofpeace
gtk-doc: fix on darwin
62e029c 
We can't use shell scripts as shebangs so we drop using .withPackages
and just add pygments to the build env to satiate meson's checks.

NixOS#71221 (comment)
@worldofpeace
Copy link
Contributor Author

@FRidh I was short on time so it was a quick fix. Updated the commit message and merging.

@worldofpeace worldofpeace merged commit 2417833 into NixOS:staging-next Oct 18, 2019
@worldofpeace worldofpeace deleted the fix-gtk-doc-quick branch October 18, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@FRidh FRidh Awaiting requested review from FRidh

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @hedning @FRidh