Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDE / Plasma updates #60889

Closed
wants to merge 9 commits into from
Closed

KDE / Plasma updates #60889

wants to merge 9 commits into from

Conversation

vandenoever
Copy link
Contributor

@vandenoever vandenoever commented May 3, 2019 •
edited

Motivation for this change

KDE software in NixOS is not at the latest version. This patch release-19.03 updates to

  • KDE frameworks 5.57
  • Plasma 5.15
  • KDE applications 19.04

I've been running my desktop on a nix channel with this patch for a few weeks. So far I've observed only one bug (https://bugs.kde.org/show_bug.cgi?id=406829). I have not been able to look into the details of the bug because:

  • I cannot get Qt 5.12.3 to compile to see if that fixes it (qt 5.12.0 -> 5.12.3 WIP #60119)
  • I do not know how to install Qt package and up with debug symbols enabled.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [~] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vandenoever vandenoever requested a review from ttuegel as a code owner May 3, 2019 19:39
@matthewbauer
Copy link
Member

This should be based off of master. Once it's merged and no significant breakages occur, we may be able to backport it to release-19.03.

@vandenoever
Copy link
Contributor Author

Ok, I'll port it to master after the Qt 5.12.3 is working on master (#60119)

@FRidh FRidh changed the title Kde KDE / Plasma updates May 4, 2019
FRidh
FRidh requested changes May 4, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to target master instead.

@FRidh
Copy link
Member

FRidh commented May 4, 2019

See also #60035

@vandenoever vandenoever mentioned this pull request May 4, 2019
Merged
17 tasks
@nyanloutre
Copy link
Member

Hello, I think this PR should be closed

@FRidh FRidh closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vandenoever @matthewbauer @FRidh @nyanloutre