Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qgroundcontrol: 3.3.0 -> 3.5.5, fix build #71308

Merged
merged 2 commits into from Oct 20, 2019
Merged

qgroundcontrol: 3.3.0 -> 3.5.5, fix build #71308

merged 2 commits into from Oct 20, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates QGroundControl to the latest version and makes it work correctly using the new QT mkDerivation.

I removed a lot of dependencies that I could not find any reference to in the code, as well as some that were only required by features which are not enabled by default.

The only issue I know of with this package is that it is unable to detect its version number, so it is shown as "None". This occurs because the build system attempts to extract the version number from git. Even if the leaveDotGit parameter is passed to fetchgit, the build system ends up extracting one of the tags fetchgit creates instead of the correct version number tag.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @therealpxc

@lopsided98 lopsided98 changed the title qgroundcontrol: 3.3.0 -> 3.5.4, fix build qgroundcontrol: 3.3.0 -> 3.5.5, fix build Oct 18, 2019
c0bw3b
c0bw3b approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on nixos

Result of nix-review pr 71308 1

1 package were build:
  • qgroundcontrol

@c0bw3b c0bw3b merged commit 8d04355 into NixOS:master Oct 20, 2019
@lopsided98 lopsided98 deleted the qgroundcontrol-update branch October 20, 2019 17:28
peti pushed a commit that referenced this pull request Oct 21, 2019
@lopsided98 @peti
qgroundcontrol: 3.3.0 -> 3.5.5, fix build (#71308)
0c17997 
* qgroundcontrol: 3.3.0 -> 3.5.4, fix build

* qgroundcontrol: 3.5.4 -> 3.5.5
@wucke13
Copy link
Contributor

wucke13 commented Nov 14, 2019

This should be backported to stable too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @wucke13 @c0bw3b