Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oxipng: 2.2.2 -> 2.3.0 #71241

Merged
merged 1 commit into from Oct 18, 2019
Merged

oxipng: 2.2.2 -> 2.3.0 #71241

merged 1 commit into from Oct 18, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Oct 16, 2019

Motivation for this change

https://github.com/shssoichiro/oxipng/blob/master/CHANGELOG.md#version-230

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 71241 1

1 package were build:
  • oxipng
$ ./results/oxipng/bin/oxipng -o 4 -i 1 --strip safe ~/Downloads/Sample-png-image-5mb.png 
Processing: /home/demo/Downloads/Sample-png-image-5mb.png
    1800x1350 pixels, PNG format
    3x8 bits/pixel, RGB
    IDAT size = 5246721 bytes
    File size = 5249494 bytes
Trying: 24 combinations
    IDAT size = 5246721 bytes (0 bytes decrease)
    file size = 5246856 bytes (2638 bytes = 0.05% decrease)
Output: /home/demo/Downloads/Sample-png-image-5mb.png

@c0bw3b c0bw3b merged commit a87d46c into NixOS:master Oct 18, 2019
@dywedir dywedir deleted the oxipng branch October 18, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dywedir @c0bw3b