Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging]python3Packages.pytest: 5.1.0 -> 5.2.1 #71240

Closed
wants to merge 4 commits into from
Closed

[staging]python3Packages.pytest: 5.1.0 -> 5.2.1 #71240

wants to merge 4 commits into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

python38Packages.pytest was broken, decided to bump while fixing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner October 16, 2019 16:43
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python38Packages.pytest

@FRidh
Copy link
Member

FRidh commented Oct 16, 2019

#71222

@FRidh
Copy link
Member

FRidh commented Oct 16, 2019

will need to cherrypick importlib into it

@jonringer
Copy link
Contributor Author

holy f**king commits... 231.... wow, you've been busy

@FRidh
Copy link
Member

FRidh commented Oct 16, 2019

many are automatically generated. Likely causes quite the breakage again.

@jonringer
Copy link
Contributor Author

I'll just review your pr then

@jonringer jonringer closed this Oct 16, 2019
@jonringer
Copy link
Contributor Author

@FRidh do you mind if I push fixes to the python-unstable branch? or does that disrupt your work flow?

@FRidh
Copy link
Member

FRidh commented Oct 16, 2019 •
edited

no, go ahead

Builds are happening at https://hydra.nixos.org/jobset/nixpkgs/python-unstable but Hydra is a bit loaded at the moment (and importlib-metadata is another rebuild again :)).

@jonringer
Copy link
Contributor Author

sounds good

@FRidh
Copy link
Member

FRidh commented Oct 16, 2019

networkx will release a new version any day now so lets ignore that its tests fail on 3.8.

@jonringer jonringer deleted the bump-pytest branch October 16, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh