New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tor-browser-bundle-bin: fix icons #71255
Conversation
-e "s,Icon=.*,Icon=tor-browser," | ||
for i in 16 32 48 64 128; do | ||
mkdir -p $out/share/icons/hicolor/''${i}x''${i}/apps/ | ||
ln -s $out/browser/chrome/icons/default/default$i.png $out/share/icons/hicolor/''${i}x''${i}/apps/tor-browser.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ln -s $out/browser/chrome/icons/default/default$i.png $out/share/icons/hicolor/''${i}x''${i}/apps/tor-browser.png | |
ln -s $out/share/tor-browser/browser/chrome/icons/default/default$i.png $out/share/icons/hicolor/''${i}x''${i}/apps/tor-browser.png |
-e "s,Icon=.*,Icon=tor-browser," | ||
for i in 16 32 48 64 128; do | ||
mkdir -p $out/share/icons/hicolor/''${i}x''${i}/apps/ | ||
ln -s $out/share/tor-browser/browser/chrome/icons/default/default$i.png $out/share/icons/hicolor/''${i}x''${i}/apps/tor-browser.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why symlink is needed, can't you just copy/move instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be used internally, which makes moving brittle. I don't see why a copy is better than a symlink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is certainly possible to copy instead of symlinking. I chose symlinking because I saw many other packages doing the same.
Please let me know if this needs to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of packages where I've used similar code like this (like brave), use symlinks.
Not sure if it's used internally, but I think copying it to another place is wasteful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can see proper icons when installed with nix-env.
backported in 8be529f |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @matejc @offlinehacker