Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyscroll: init at 2.19.2 #71257

Closed
wants to merge 1 commit into from
Closed

pyscroll: init at 2.19.2 #71257

wants to merge 1 commit into from

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Oct 16, 2019

Motivation for this change

Add the pyscroll library

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@oxzi oxzi requested a review from FRidh as a code owner October 16, 2019 20:55
jonringer
jonringer reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pull from github so that we can have some tests, just unittests are good :)

Unfortunately you'll have to match the date to a commit to figure out the version github, as they didn't use a tag/release mechanism there.

pkgs/development/python-modules/pyscroll/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyscroll/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyscroll/default.nix Outdated Show resolved Hide resolved
@oxzi
Copy link
Member Author

oxzi commented Oct 17, 2019

Thanks a lot for your feedback.

I had some problems with the upstream tests. The demo tests are relying on pyTMX, which is still in proceeding in #71258, and the small unit tests were not updated with the rest of the code and are breaking.
Thus, I have not changed the src because the tests are currently useless.

@jonringer
Copy link
Contributor

I would focus on just unit tests, if they make the distinction.

@oxzi
Copy link
Member Author

oxzi commented Oct 17, 2019

I have opened an issue regarding the failing tests in the upstream repository bitcraft/pyscroll#34

FRidh
FRidh approved these changes Feb 9, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merge conflict needs to be resolved though.

FRidh
FRidh requested changes Feb 9, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, the tests...

@mweinelt
Copy link
Member

Seems like the upstream has put work into the tests. Can you give it another try @geistesk?

@oxzi oxzi closed this Jul 19, 2020
@oxzi oxzi deleted the pyscroll-2.19.2 branch July 19, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @jonringer @mweinelt @FRidh