Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytmx: init at 3.21.7 #71258

Merged
merged 1 commit into from Oct 17, 2019
Merged

pytmx: init at 3.21.7 #71258

merged 1 commit into from Oct 17, 2019

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Oct 16, 2019

Motivation for this change

Adds the PyTMX library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@oxzi oxzi requested a review from FRidh as a code owner October 16, 2019 20:56
jonringer
jonringer reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM code wise, but there's no tests. Please pull from the github release so that we can have tests :) (They are important to making sure that your package doesn't get broken by upstream package bumps)

pkgs/development/python-modules/pytmx/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytmx/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytmx/default.nix Outdated Show resolved Hide resolved
@oxzi oxzi mentioned this pull request Oct 17, 2019
Closed
10 tasks
@oxzi
Copy link
Member Author

oxzi commented Oct 17, 2019

@jonringer: Thanks a lot for your review. I have updated the PR.

jonringer
jonringer approved these changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
leaf package

[5 built, 18 copied (58.1 MiB), 11.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71258
3 package were build:
python27Packages.pytmx python37Packages.pytmx python38Packages.pytmx

@jonringer jonringer merged commit ab42edc into NixOS:master Oct 17, 2019
@oxzi oxzi deleted the pytmx-3.21.7 branch October 17, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxzi @jonringer