gnome3.gnome-online-accounts: build with meson #71260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have to fetch from gitlab as it's not distributed yet. See [0] and [1]. [0]: https://gitlab.gnome.org/GNOME/gnome-online-accounts/merge_requests/2#note_271132 [1]: https://gitlab.gnome.org/GNOME/gnome-online-accounts/issues/87
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Oct 28, 2019
gnome3.gnome-online-accounts: build with meson (cherry picked from commit d674b9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See 5366676 for meson port. Unfortunately had to add
NIX_CFLAGS_COMPILE = "-I${glib.dev}/include/gio-unix-2.0", wasn't sure how fix that with the generated code.I've also disabled the Fedora provider as it's not useful for NixOS users.
(though the icons are still installed by the buildsystem?)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)