Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obinskit: init at 1.1.1 #71259

Merged
merged 1 commit into from Mar 14, 2020
Merged

obinskit: init at 1.1.1 #71259

merged 1 commit into from Mar 14, 2020

Conversation

Shou
Copy link
Contributor

@Shou Shou commented Oct 16, 2019

Motivation for this change

This is the configuration software for the enthusiast Anne Pro mechanical keyboard, used to update the firmware, change keyboard settings, clear Bluetooth connections from the device, set up backlighting colours, and so forth. I'm an owner of one and don't think I'm alone so I thought it'd be convenient to have this packaged. They have an official Github, but the software is proprietary to my knowledge (no license provided).

I've tested that the software works with my own Anne Pro II.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented Oct 20, 2019

@GrahamcOfBorg eval

@Shou
Copy link
Contributor Author

Shou commented Oct 28, 2019

I've removed libffmpeg.so and libnode.so because electron_3 already provides these.

worldofpeace
worldofpeace suggested changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set

dontConfigure = true;
dontBuild = true;

as the build fails trying to run these phases.

Also see my suggestion about using makeWrapper and the use of aliases in this pr.

pkgs/applications/misc/obinskit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/obinskit/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/obinskit/default.nix Outdated Show resolved Hide resolved
@Shou
obinskit: init at 1.1.1
e0ec7b7 
This is the configuration software for the enthusiast Anne Pro mechanical
keyboard, used to update the firmware, change keyboard settings, clear
Bluetooth connections from the device, set up backlighting colours, and so
forth.
@Shou
Copy link
Contributor Author

Shou commented Nov 25, 2019

@worldofpeace thanks for the CR, I should've taken care of the feedback now, and squashed.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/110

jonringer
jonringer approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
app opens fine

[4 built, 2 copied (123.9 MiB), 36.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/71259
1 package built:
obinskit

@jonringer jonringer merged commit 51fa3d3 into NixOS:master Mar 14, 2020
@Shou Shou deleted the init-obinskit branch March 16, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Shou @mmahut @nixos-discourse @jonringer @worldofpeace