Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2332cb7dbc2c
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2bd4f8023bff
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 18, 2019

  1. bustle: fix build

    jtojnar committed Oct 18, 2019
    Copy the full SHA
    538d9cb View commit details
  2. Copy the full SHA
    2bd4f80 View commit details
5 changes: 2 additions & 3 deletions pkgs/desktops/gnome-3/extensions/gsconnect/default.nix
Original file line number Diff line number Diff line change
@@ -4,21 +4,20 @@

stdenv.mkDerivation rec {
pname = "gnome-shell-gsconnect";
version = "26";
version = "27";

src = fetchFromGitHub {
owner = "andyholmes";
repo = "gnome-shell-extension-gsconnect";
rev = "v${version}";
sha256 = "01p8b3blsnxi2i89nddkm51wbbw5irwii2qlvlrzfh8hhh37my0a";
sha256 = "0bpg7hl81wir3c15ri8kbvr6xhalpkfmcyazwmmwyj5lxpn40ykk";
};

patches = [
# Make typelibs available in the extension
(substituteAll {
src = ./fix-paths.patch;
gapplication = "${glib.bin}/bin/gapplication";
mutter_gsettings_path = glib.getSchemaPath gnome3.mutter;
})
];

29 changes: 0 additions & 29 deletions pkgs/desktops/gnome-3/extensions/gsconnect/fix-paths.patch
Original file line number Diff line number Diff line change
@@ -29,32 +29,3 @@
const Gio = imports.gi.Gio;
const GLib = imports.gi.GLib;
const Gtk = imports.gi.Gtk;
--- a/src/preferences/service.js
+++ b/src/preferences/service.js
@@ -435,9 +435,9 @@ var Window = GObject.registerClass({

_restoreGeometry() {
if (this._mutterSettings === undefined) {
- this._mutterSettings = new Gio.Settings({
- schema_id: 'org.gnome.mutter'
- });
+ const _schema_source = Gio.SettingsSchemaSource.new_from_directory('@mutter_gsettings_path@', Gio.SettingsSchemaSource.get_default(), true);
+ const _schema = _schema_source.lookup('org.gnome.mutter', false);
+ this._mutterSettings = new Gio.Settings({settings_schema: _schema});
}

// Restore geometry, even if we're going to maximize
--- a/src/service/ui/messaging.js
+++ b/src/service/ui/messaging.js
@@ -891,9 +891,9 @@ var Window = GObject.registerClass({
*/
_restoreGeometry() {
if (this._mutterSettings === undefined) {
- this._mutterSettings = new Gio.Settings({
- schema_id: 'org.gnome.mutter'
- });
+ const _schema_source = Gio.SettingsSchemaSource.new_from_directory('@mutter_gsettings_path@', Gio.SettingsSchemaSource.get_default(), true);
+ const _schema = _schema_source.lookup('org.gnome.mutter', false);
+ this._mutterSettings = new Gio.Settings({settings_schema: _schema});
}

16 changes: 15 additions & 1 deletion pkgs/development/haskell-modules/configuration-common.nix
Original file line number Diff line number Diff line change
@@ -589,9 +589,23 @@ self: super: {
sets = dontCheck super.sets;

# Install icons, metadata and cli program.
bustle = overrideCabal super.bustle (drv: {
# Do not build hgettext as it is broken
# https://gitlab.freedesktop.org/bustle/bustle/issues/13
bustle = overrideCabal (disableCabalFlag (super.bustle.override { hgettext = null; }) "hgettext") (drv: {
buildDepends = [ pkgs.libpcap ];
buildTools = with pkgs.buildPackages; [ gettext perl help2man ];
patches = [
# fix build
# https://gitlab.freedesktop.org/bustle/bustle/merge_requests/14
(pkgs.fetchpatch {
url = "https://gitlab.freedesktop.org/bustle/bustle/commit/ee4b81cbc232d47ba9940f1987777b17452e71ff.patch";
sha256 = "0v9cvbmrma5jcqcg1narpm1549h0cg8mr6i00qxmq0x6hs04dnwa";
})
(pkgs.fetchpatch {
url = "https://gitlab.freedesktop.org/bustle/bustle/commit/aae6843f51f54679d440fb3813e61355dc8406b9.patch";
sha256 = "1a8hr38hd1gdkqhsy56hyl7njw8ci79iigr81aalkb7hn4ckvh2a";
})
];
postInstall = ''
make install PREFIX=$out
'';