Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aqbanking #71304

Closed
Closed

Conversation

thorstenweber83
Copy link
Contributor

@thorstenweber83 thorstenweber83 commented Oct 18, 2019

Motivation for this change

Update aqbanking for use with kmymoney/gnucash.
I used the newest (on github) available beta releases/release candidates because kmymoney 5.0.7 demands beta versions (aqbanking 5.99.32+ and gwenhywfar 4.99.16+) so when we already use unstable releases we can as well take the newest available.

Things done

I can connect to my bank's HBCI Server using kmymoney 5.0.7 (#69616) on top of this.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cillianderoiste

Copy link
Member

@aszlig aszlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request.

As mentioned, I'm against using third-party mirrors for the sources, except when we can check that its contents are equal to the actual release tarball. Using the Git repository instead of the tarball makes this harder.

owner = "aqbanking";
repo = "aqbanking";
rev = version;
sha256 = "1p80cmzy2c0k17vknpsywr9ywimak09y3lvyhvc3dyqfcr0xnbm9";
Copy link
Member

@aszlig aszlig Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use something like https://www.aquamaniac.de/rdm/attachments/download/207/aqbanking-5.99.41beta.tar.gz (btw. 5.99.41 is out) here? The tarballs seem to have stable links and even if they become unstable, we have a tarball mirror at https://tarballs.nixos.org/. Using a mirror from someone other than the original maintainer really opens up another possibility where malicious code can be injected (especially cruicial if it comes to online banking).

There is also another issue with beta versions, because as far as I can see only the stable releases are signed and I usually verify these signatures (in this case manuall) when updating, so what's the reason why kmymoney wants the beta?

Copy link
Contributor

@dpaetzel dpaetzel Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would really like to have this PR go through, too 😉

The link per se is stable but their server is down pretty often (multiple times per hour, each for several minutes—at least when I tried to create this PR myself two week ago).

We need the beta because of PSD2 being in effect; IIRC the non-beta builds do not yet support the new interface (which makes them entirely unusable, as in, you can't connect to any bank).

EDIT: I misread, didn't know that 5.99.41 is out already. Sorry!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aszlig
When creating the pr upstream wasn't reachable at all.
Now it's better and i updated the pr to reflect your concerns about 3rd party sources.
I also have the impression that PSD2 is only supported by the beta versions.
I understand your concerns about using beta releases.
But not being able to use aqbanking at all is worse than not being able to verify the signature in my opinion.
When there is a usable non-beta release we should of course go back to using that.

pkgs/development/libraries/aqbanking/gwenhywfar.nix Outdated Show resolved Hide resolved
@dpaetzel
Copy link
Contributor

Is there any news on this PR? @thorstenweber83 , are you sure that the version of aqbanking you packaged supports PSD2? In my case, using your PR, my bank answers me to upgrade to a PSD2 compatible version … But that might be due to some misconfiguration on my side?

@thorstenweber83
Copy link
Contributor Author

@dpaetzel i just used kmymony built with this pr to fetch my account activity on my "Volkbank Odenwald" bank account.
I had to update my itanmode once using aqhbci-tool4's setitanmode command, but then i could use my smart tan device to generate a tan.

Also i just updated the pr to the latest aqbanking + gwenhywfar.

@dpaetzel
Copy link
Contributor

OK, I updated and redid all the setup work once more (this time, more closely following this guide) and now I managed to download transactions.

Also, thanks for keeping this PR up to date 🙂

@clkamp clkamp mentioned this pull request Feb 27, 2020
10 tasks
Also add patch to be able to build aqbanking 5.7.8. It can be removed for newer  aqbanking (5.9.x) versions.
@thorstenweber83
Copy link
Contributor Author

updated to 6.1.1 and tested with kmymoney.

@thorstenweber83
Copy link
Contributor Author

closing this since #81176 has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants