Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oracle-instantclient: Fix path for darwin downloads #71268

Merged
merged 1 commit into from Oct 18, 2019
Merged

oracle-instantclient: Fix path for darwin downloads #71268

merged 1 commit into from Oct 18, 2019

Conversation

jsamsa
Copy link
Contributor

@jsamsa jsamsa commented Oct 16, 2019 •
edited by aanderse

Motivation for this change

download for oracle-instantclient was failing on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pesterhazy @flokli

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Oct 16, 2019
@jsamsa jsamsa changed the title Fix path for darwin downloads oracle-instantclient: Fix path for darwin downloads Oct 17, 2019
@jsamsa jsamsa force-pushed the fix-macos-oracle-instantclient branch from 14588cb to 6fd2b74 Compare October 17, 2019 13:55
@flokli flokli requested a review from aanderse October 17, 2019 14:05
aanderse
aanderse approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloads and builds correctly, but I cannot actually test this on darwin.

Worth noting:

  • perlPackages.DBDOracle fails, though I'm pretty sure that was the case before this PR
  • phpPackages.oci8 builds successfully

Thank you for fixing this @jsamsa!

@aanderse aanderse merged commit 5617886 into NixOS:master Oct 18, 2019
@jsamsa
Copy link
Contributor Author

jsamsa commented Oct 18, 2019

I did test on darwin through pythonPackages.cx_oracle against a live database. I'll try to find a little time to investigate the issue with perl.

@aanderse
Copy link
Member

@jsamsa like I said I'm pretty sure that was existing issue. Don't feel obliged.

That being said... any time you fix a broken package in nixpkgs full bonus points awarded 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsamsa @aanderse