Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed SystemWebViewShell's use of is_alive property. #19166

Merged
merged 2 commits into from Oct 11, 2019
Merged

Fixed SystemWebViewShell's use of is_alive property. #19166

merged 2 commits into from Oct 11, 2019

Conversation

cmumford
Copy link
Contributor

SystemWebViewShell.is_alive() was referencing the
ChromeDriverServer.is_alive property (inherited from WebDriverServer),
but calling it as if it were a function. Encountered this when
running wpt run --debugger ...

@cmumford
Fixed SystemWebViewShell's use of is_alive property.
560ecb4 
SystemWebViewShell.is_alive() was referencing the
ChromeDriverServer.is_alive property (inherited from WebDriverServer),
but calling it as if it were a function. Encountered this when
running `wpt run --debugger ...`
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Sep 19, 2019
gsnedders
gsnedders reviewed Oct 4, 2019
View reviewed changes
Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grepping it through it, it appears like we get this wrong in essentially every browser. I think just doing this line-for-line replacement throughout the directory is all that's needed. Could you fix this elsewhere too?

@cmumford
Copy link
Contributor Author

cmumford commented Oct 4, 2019

Good point @gsnedders - fixed for all browsers.

@cmumford
Copy link
Contributor Author

ping. Is this blocked on me?

@gsnedders
Copy link
Member

No, blocked on me attending/speaking at a conference and nobody else responding. 🙂

@gsnedders gsnedders merged commit 8be26a0 into web-platform-tests:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders gsnedders approved these changes

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jgraham jgraham

Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cmumford @gsnedders @jgraham @wpt-pr-bot