Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gscan2pdf: 2.5.5 -> 2.5.6 #69036

Merged
merged 1 commit into from Sep 23, 2019
Merged

gscan2pdf: 2.5.5 -> 2.5.6 #69036

merged 1 commit into from Sep 23, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Sep 18, 2019

Motivation for this change

Updating gscan2pdf to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@pacien
Copy link
Contributor Author

pacien commented Sep 18, 2019 •
edited

@GrahamcOfBorg build gscan2pdf

@pacien
Copy link
Contributor Author

pacien commented Sep 22, 2019

The build of a transitive dependency (gcj) seems to fail on aarch64-linux on ofborg.
Should I disable this package (gscan2pdf) for this architecture?

This package otherwise builds and runs fine on x86_64_linux.

@Mic92
Copy link
Member

Mic92 commented Sep 22, 2019 •
edited

@pacien gcj should be marked as broken on aarch64 instead. This would propagate to gscan2pdf as well.

@Mic92 Mic92 merged commit fbfdaed into NixOS:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @Mic92