Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-{web,desktop}: 1.3.3 -> 1.3.5 #69035

Merged
merged 2 commits into from Sep 18, 2019
Merged

riot-{web,desktop}: 1.3.3 -> 1.3.5 #69035

merged 2 commits into from Sep 18, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Sep 18, 2019

Motivation for this change

Updating Riot to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bachp @worldofpeace

@ofborg ofborg bot requested a review from worldofpeace September 18, 2019 16:52
worldofpeace
worldofpeace approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works.

@worldofpeace worldofpeace merged commit 0d11e85 into NixOS:master Sep 18, 2019
@worldofpeace
Copy link
Contributor

Actually, shouldn't have yarndeps changed further element-hq/element-web@v1.3.5-rc.3...v1.3.5?

@pacien
Copy link
Contributor Author

pacien commented Sep 18, 2019

Actually, shouldn't have yarndeps changed further vector-im/riot-web@v1.3.5-rc.3...v1.3.5?

No, riot-web/electron_app/yarn.lock hasn't changed between those releases.

@worldofpeace
Copy link
Contributor

I meant shouldn't have https://github.com/pacien/nixpkgs/blob/e32515aa92b3982e26915175339444b4d0c6ef22/pkgs/applications/networking/instant-messengers/riot/riot-desktop-yarndeps.nix changed?

@pacien
Copy link
Contributor Author

pacien commented Sep 18, 2019

I meant shouldn't have https://github.com/pacien/nixpkgs/blob/e32515aa92b3982e26915175339444b4d0c6ef22/pkgs/applications/networking/instant-messengers/riot/riot-desktop-yarndeps.nix changed?

riot-desktop-yarndeps.nix is generated from riot-web/electron_app/yarn.lock, not riot-web/yarn.lock, which is the one that changed.

@worldofpeace
Copy link
Contributor

Understood. Thanks for explaining @pacien 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @worldofpeace