Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.python-language-server: add setuptools as a de… #69117

Merged
merged 1 commit into from Sep 21, 2019
Merged

python3Packages.python-language-server: add setuptools as a de… #69117

merged 1 commit into from Sep 21, 2019

Conversation

symphorien
Copy link
Member

Motivation for this change

pyls was failing with ModuleNotFoundError: No module named 'pkg_resources'

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@ofborg ofborg bot requested a review from Mic92 September 19, 2019 19:48
@symphorien
Copy link
Member Author

cc #68314

@Mic92 Mic92 changed the title python3Packages.python-language-server: add setuptools as a dependency python3Packages.python-language-server: add setuptools as a de… Sep 21, 2019
@Mic92 Mic92 merged commit 970145f into NixOS:master Sep 21, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2019

[detached HEAD 2306020] python3Packages.python-language-server: add setuptools as a dependency
Author: Symphorien Gibol symphorien+git@xlumurb.eu
Date: Thu Sep 19 14:13:04 2019 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

@symphorien symphorien deleted the pyls-setuptools branch September 26, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@symphorien @Mic92