Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dont merge/[ci] librsvg: 2.44.14 → 2.46.0 #69118

Closed
wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Testing https://gitlab.gnome.org/GNOME/librsvg/issues/456 on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace worldofpeace changed the title [dont merge] librsvg: 2.44.14 → 2.46.0 [dont merge/[ci] librsvg: 2.44.14 → 2.46.0 Sep 19, 2019
@ofborg ofborg bot requested review from hedning and jtojnar September 19, 2019 20:20
@worldofpeace
Copy link
Contributor Author

Confirmed this works on darwin, what kind of magic is this 😄
@matthewbauer Guess we can close https://gitlab.gnome.org/GNOME/librsvg/issues/456.

@worldofpeace worldofpeace deleted the test-librsvg branch September 19, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants