Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

djview: adopt, upd {descriptions, to qt5}, add features #69061

Merged
merged 1 commit into from Sep 24, 2019
Merged

djview: adopt, upd {descriptions, to qt5}, add features #69061

merged 1 commit into from Sep 24, 2019

Conversation

Anton-Latukha
Copy link
Contributor

Motivation for this change

  1. Adopting a package.

  2. Update from Qt4 to Qt5, it is supported officially: https://sourceforge.net/p/djvu/djview-git/ci/master/tree/NEWS.

  3. Descriptions now provide needed facts.

  4. Enabling features via config flags (now we actually using declared deps).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Anton-Latukha Anton-Latukha mentioned this pull request Sep 19, 2019
Closed
peterhoeg
peterhoeg requested changes Sep 19, 2019
View reviewed changes
pkgs/applications/graphics/djview/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/djview/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/djview/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/djview/default.nix Outdated Show resolved Hide resolved
@Anton-Latukha
Copy link
Contributor Author

@GrahamcOfBorg build djview

@Anton-Latukha
Copy link
Contributor Author

Seems like Borg build, but not returned result into GH.

@Anton-Latukha
Copy link
Contributor Author

@GrahamcOfBorg build djview

@peterhoeg
Copy link
Member

If the build check passes, this is good to squash and merge.

@Anton-Latukha
djview: {adopt, clean-up, doc, Qt(4 -> 5), add features}
cc79524 
djview: adopt

djview: upd description

djview: add longDescription

djview: upd to Qt5, use Qt5's mkDerivation

djview: add configureFlags (enabling couple features)

upd longDescription

djview: upd clean-up
@Anton-Latukha
Copy link
Contributor Author

Squash - done.

@peterhoeg peterhoeg merged commit 6d2e24e into NixOS:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg peterhoeg approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anton-Latukha @peterhoeg