Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circleci-cli: 0.1.2569 -> 0.1.5879 #69062

Merged
merged 1 commit into from Sep 19, 2019
Merged

circleci-cli: 0.1.2569 -> 0.1.5879 #69062

merged 1 commit into from Sep 19, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 18, 2019

Motivation for this change

Fixes #69047
cc: @matthew-piziak

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@symbiont-matthew-piziak
Copy link

Thank you!!

@ofborg ofborg bot requested a review from kalbasit September 19, 2019 00:00
jonringer
jonringer approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

@marsam marsam merged commit 2c90666 into NixOS:master Sep 19, 2019
@marsam marsam deleted the update-circleci-cli branch September 19, 2019 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: circleci-cli
3 participants
@marsam @symbiont-matthew-piziak @jonringer