Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.premailer: fix build #69063

Merged
merged 1 commit into from Sep 19, 2019
Merged

pythonPackages.premailer: fix build #69063

merged 1 commit into from Sep 19, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 19, 2019 •
edited

Motivation for this change

noticed it was broken while reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69063
2 package were build:
python27Packages.premailer python37Packages.premailer

@teto teto merged commit 1728793 into NixOS:master Sep 19, 2019
@jonringer jonringer deleted the fix-premailer branch September 19, 2019 22:27
@Ma27
Copy link
Member

Ma27 commented Oct 1, 2019

Backported as 8d7f2c7 to fix the Hydra build (https://hydra.nixos.org/build/102506732).

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @Ma27 @teto