Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osmid: init at 0.6.8 #69084

Merged
merged 1 commit into from Sep 20, 2019
Merged

osmid: init at 0.6.8 #69084

merged 1 commit into from Sep 20, 2019

Conversation

c0deaddict
Copy link
Member

Motivation for this change

Osmid is an optional dependency of Sonic-Pi to communicatie to and from MIDI devices.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@aanderse
Copy link
Member

aanderse commented Sep 19, 2019 •
edited

I wonder if the bot is still on the fritz...
@GrahamcOfBorg build osmid

aanderse
aanderse requested changes Sep 19, 2019
View reviewed changes
pkgs/applications/audio/osmid/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/osmid/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

ping @grahamc for another example of bot not building.

@c0deaddict
Copy link
Member Author

Thanks for your review! I've made the changes.

alexarice
alexarice approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds with nix-review on nixos and runs (at least the help messages do)

aanderse
aanderse requested changes Sep 20, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c0deaddict I apologize I didn't get back to this yesterday. I meant to during my lunch hour but ended up busier than expected. 2 minor changes and then based on testing by @alexarice we're good to go 👍

pkgs/applications/audio/osmid/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/osmid/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build osmid

aanderse
aanderse approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@aanderse aanderse merged commit 8310533 into NixOS:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@alexarice alexarice alexarice approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0deaddict @aanderse @alexarice