Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beets: 1.4.7 -> 1.4.9 #69067

Merged
merged 1 commit into from Sep 23, 2019
Merged

beets: 1.4.7 -> 1.4.9 #69067

merged 1 commit into from Sep 23, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Sep 19, 2019

Motivation for this change

I just want to be able to update gmusicapi to 12.1.1 (which breaks beets).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aszlig @domenkozar @pjones

Note that I think I need help with https://github.com/beetbox/beets/blob/master/docs/plugins/loadext.rst . I have no idea what to do. The package builds without having to add those icu deps.

❯ nix path-info -S /nix/store/nh7cxg3yv8mw1ar6jrn8mv91qhv192jz-beets-1.4.7
/nix/store/nh7cxg3yv8mw1ar6jrn8mv91qhv192jz-beets-1.4.7 809106272

❯ nix path-info -S /nix/store/07ai6p8hrc9mapy95w7yb0zxpsi3hizi-beets-1.4.9
/nix/store/07ai6p8hrc9mapy95w7yb0zxpsi3hizi-beets-1.4.9 809232656

@pjones
Copy link
Contributor

pjones commented Sep 19, 2019

@bbigras I'll have to read up on loadext since I'm not familiar with it.

@pjones
Copy link
Contributor

pjones commented Sep 19, 2019

@np Do we have a way of building SQLite extensions or enabling them via an override? Specifically, this PR would need to enable the ICU extension for a single Python application.

Thanks!

@aszlig
Copy link
Member

aszlig commented Sep 23, 2019

@bbigras: IIUC, the ICU extension is only needed if you want to search case-insensitively, but since we didn't have it so far, I think nobody will be hurt if it still isn't supported.

@ofborg ofborg bot requested a review from aszlig September 23, 2019 04:40
@Mic92 Mic92 merged commit c7dfc9e into NixOS:master Sep 23, 2019
@bbigras bbigras deleted the beets branch September 23, 2019 15:05
@bbigras
Copy link
Contributor Author

bbigras commented Sep 23, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenkozar domenkozar Awaiting requested review from domenkozar

@pjones pjones Awaiting requested review from pjones

@aszlig aszlig Awaiting requested review from aszlig

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbigras @pjones @aszlig @Mic92