Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typora: build without electron_5 dependency #69065

Closed
wants to merge 1 commit into from
Closed

typora: build without electron_5 dependency #69065

wants to merge 1 commit into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Sep 19, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jensbin @worldofpeace

@eadwu
Copy link
Member Author

eadwu commented Sep 19, 2019

Can't patch in hunspell dicts [path] unless one of the asar archives are unpacked and then patched[ and then recompressed]. Their implementation is clunky, since they just clone the read-only directory if it doesn't exist to ~/.config/Typora/dictionaries and it ends up being empty.

@worldofpeace
Copy link
Contributor

Why not wrap with electron_5? I found it to be much simpler to use the electron we have in nixpkgs.

@eadwu
Copy link
Member Author

eadwu commented Sep 20, 2019

#69129.

@eadwu eadwu closed this Sep 20, 2019
@eadwu eadwu deleted the typora/no-electron branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jensbin jensbin Awaiting requested review from jensbin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @worldofpeace