Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitea: fix dump #69195

Merged
merged 1 commit into from Sep 21, 2019
Merged

nixos/gitea: fix dump #69195

merged 1 commit into from Sep 21, 2019

Conversation

c0deaddict
Copy link
Member

Motivation for this change

Gitea dump is broken on unstable.

export GITEA_WORK_DIR=/var/lib/gitea /nix/store/6qp5izcvfrc1gmlghnj6ac6krw2ccy5x-gitea-1.9.3-bin/bin/gitea dump -V

Exits with status 1 and with a dump file of just 22 bytes.

Looking through strace output, found this:

openat(AT_FDCWD, "/var/lib/gitea/log", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)

After a mkdir /var/lib/gitea/log dump is working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@etu etu merged commit 89b0ef6 into NixOS:master Sep 21, 2019
@etu
Copy link
Contributor

etu commented Sep 21, 2019

@c0deaddict Mind backporting this to 19.09 as well? Possibly even 19.03

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 21, 2019

Just checked and it's a problem even in stable.

@c0deaddict
Copy link
Member Author

@etu How does the backporting work, making this PR but the against branches release-19.03 and release-19.09?

@etu
Copy link
Contributor

etu commented Sep 21, 2019

@c0deaddict Yes, normally you would do like this:
Checkout release-19.03 and release-19.09 (one at the time) and run:
git cherry-pick -x 86b83f37b8e70542287195a52dc1b3fd9c33143d (the commit id is the one from this PR)

And put those in their own branches respectively and make PR's for those branches :)

Just ping me afterwards and I'll merge it :)

This was referenced Sep 21, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0deaddict @etu @rnhmjoj