nixos/postgresql: switch default 9.6 -> 11 #69194
Conversation
This is designed for 19.09 release.
ofborg
bot
added
6.topic: nixos
|
Also note, existing tests don't cover this change, as those set pg version explicitly. |
ofborg
bot
added
10.rebuild-darwin: 0
|
hm. On a second thought, there are other services which use PG, which have to be tested:
|
This change affects packages that refers to postgres in order to get access to the client code, libpq, and these packages will now be compiled supporting the latest version. This change does not affect NixOS, i.e. people who want to run a PostgreSQL server. The NixOS module always refers to specific versions of 'postgres', so if you want to use the latest version there, too, then you'll have to configure your system appropriately in configuration.nix. See NixOS#69194 for an effort to update the NixOS module, too. Fixes NixOS#69141.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixos-19-09-feature-freeze/3707/16 |
There was a problem hiding this comment.
Since PostgreSQL 9.6 is only supported until 2020-02-13 which is in our support time frame for 19.09, I welcome this change. Provided we can test the relevant services in time of course.
Even we don't remove PostgreSQL 9.6 now, we will at least mark it as insecure in February 2020. Since PostgreSQL upgrades require manual work, we shouldn't force this unnecessarily on our users after the release of a stable version.
Sorry, I was looking at the wrong version. For 20.03 of course!
This change affects packages that refers to postgres in order to get access to the client code, libpq, and these packages will now be compiled supporting the latest version. This change does not affect NixOS, i.e. people who want to run a PostgreSQL server. The NixOS module always refers to specific versions of 'postgres', so if you want to use the latest version there, too, then you'll have to configure your system appropriately in configuration.nix. See NixOS#69194 for an effort to update the NixOS module, too. Fixes NixOS#69141. (cherry picked from commit 28b8d6b)
|
so, is this good to merge now? |
nixos/postgresql: switch default 9.6 -> 11 (cherry picked from commit 8cd5aa8)
#69141
This is designed to be merged fast for 19.09 release. 20.03 or 20.09 should then include PG12.
This may break beta-19.09 and nixos-unstable, but it shouldn't be a problem after 19.09 release.
I should have this done before 19.03 was branched off. Maybe we should learn from this and already declare 20.09 as Pg12.
cc @peti @disassembler