Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/postgresql: switch default 9.6 -> 11 #69194

Merged
merged 2 commits into from Oct 2, 2019
Merged

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Sep 21, 2019

#69141

This is designed to be merged fast for 19.09 release. 20.03 or 20.09 should then include PG12.

This may break beta-19.09 and nixos-unstable, but it shouldn't be a problem after 19.09 release.
I should have this done before 19.03 was branched off. Maybe we should learn from this and already declare 20.09 as Pg12.

cc @peti @disassembler

This is designed for 19.09 release.
@danbst
Copy link
Contributor Author

danbst commented Sep 21, 2019

Also note, existing tests don't cover this change, as those set pg version explicitly.

@danbst
Copy link
Contributor Author

danbst commented Sep 21, 2019

hm. On a second thought, there are other services which use PG, which have to be tested:

  • mattermost
  • miniflux
  • restya-board
  • bacula
  • openfire
  • meguca
  • matrix-synapse
  • hydra

peti added a commit to peti/nixpkgs that referenced this pull request Sep 21, 2019
This change affects packages that refers to postgres in order to get access to
the client code, libpq, and these packages will now be compiled supporting the
latest version.

This change does not affect NixOS, i.e. people who want to run a PostgreSQL
server. The NixOS module always refers to specific versions of 'postgres', so
if you want to use the latest version there, too, then you'll have to configure
your system appropriately in configuration.nix.

See NixOS#69194 for an effort to update the
NixOS module, too.

Fixes NixOS#69141.
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this change for nixos-20.03 is the right choice, IMHO. I would not try to push this into 19.09. It's too late for that.

EDIT: Sorry, got my version numbers mixed up in the original comment.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixos-19-09-feature-freeze/3707/16

@peti peti self-requested a review September 21, 2019 13:35
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this change for nixos-20.03 is the right choice, IMHO. I would not try to push this into 19.09. It's too late for that.

EDIT: Sorry, got my version numbers mixed up in the original comment.

fpletz
fpletz previously approved these changes Sep 21, 2019
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since PostgreSQL 9.6 is only supported until 2020-02-13 which is in our support time frame for 19.09, I welcome this change. Provided we can test the relevant services in time of course.

Even we don't remove PostgreSQL 9.6 now, we will at least mark it as insecure in February 2020. Since PostgreSQL upgrades require manual work, we shouldn't force this unnecessarily on our users after the release of a stable version.

Sorry, I was looking at the wrong version. For 20.03 of course!

@fpletz fpletz added this to the 20.03 milestone Sep 21, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 22, 2019
This change affects packages that refers to postgres in order to get access to
the client code, libpq, and these packages will now be compiled supporting the
latest version.

This change does not affect NixOS, i.e. people who want to run a PostgreSQL
server. The NixOS module always refers to specific versions of 'postgres', so
if you want to use the latest version there, too, then you'll have to configure
your system appropriately in configuration.nix.

See NixOS#69194 for an effort to update the
NixOS module, too.

Fixes NixOS#69141.

(cherry picked from commit 28b8d6b)
@Lassulus
Copy link
Member

Lassulus commented Oct 2, 2019

so, is this good to merge now?

@peti peti merged commit 8cd5aa8 into NixOS:master Oct 2, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 2, 2019
nixos/postgresql: switch default 9.6 -> 11

(cherry picked from commit 8cd5aa8)
@danbst danbst deleted the pg11-nixos branch October 4, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants