Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk8: add setJavaClassPath-hook to jdk as well #69137

Merged
merged 1 commit into from Sep 21, 2019
Merged

openjdk8: add setJavaClassPath-hook to jdk as well #69137

merged 1 commit into from Sep 21, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 20, 2019 •
edited

Motivation for this change

This hook got removed from JDK[1], however without this hook,
the classpath in a Java-build isn't created anymore which caused
several[2][3] broken packages.

[1] https://github.com/NixOS/nixpkgs/pull/65247/files#r324459267
[2] https://hydra.nixos.org/build/100896633
[3] https://hydra.nixos.org/build/100895668

ZHF #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 20, 2019
@ofborg ofborg bot requested review from NeQuissimus and edwtjo September 20, 2019 08:34
@Ma27
openjdk8: add setJavaClassPath-hook to jdk as well
19f8806 
This hook got removed from JDK[1], however without this hook,
the classpath in a Java-build isn't created anymore which caused
several[2][3] broken packages.

[1] https://github.com/NixOS/nixpkgs/pull/65247/files#r324459267
[2] https://hydra.nixos.org/build/100896633
[3] https://hydra.nixos.org/build/100895668

ZHF NixOS#68361
@Ma27 Ma27 force-pushed the fix-openjdk-java-classpath-setup-hook branch from 4648adf to 19f8806 Compare September 20, 2019 19:40
@Mic92 Mic92 merged commit ae07f6c into NixOS:master Sep 21, 2019
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2019

[detached HEAD f7f4387] openjdk8: add setJavaClassPath-hook to jdk as well
Author: Maximilian Bosch maximilian@mbosch.me
Date: Fri Sep 20 10:11:00 2019 +0200
1 file changed, 2 insertions(+)

@Ma27 Ma27 deleted the fix-openjdk-java-classpath-setup-hook branch September 21, 2019 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @Mic92 @NeQuissimus