Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/ofborg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d908e5d450be
Choose a base ref
...
head repository: NixOS/ofborg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f2a893c9ff81
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Aug 13, 2019

  1. maintainers: compare maintainer usernames in lowercase 

    At least a few maintainers in <nixpkgs>/maintainers/maintainer-list.nix
specified a lowercase username for GitHub while actually having a
username with upper case characters.
Ofborg performs case-sensitive comparisons on PR submitters and the
above mentioned usernames. This causes borg to not recognize users when
there is different casing between the above list and the 'user.name'
value of github's api response, even though the casing is irrelevant for
distinguishing different users.
    @WilliButz
    WilliButz committed Aug 13, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    WilliButz
    GPG key ID: 92582A10F1179CB2
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    a1b1315 View commit details

Commits on Sep 19, 2019

  1. Merge pull request #384 from WilliButz/fix-maintainer-detection 

    maintainers: compare maintainer usernames in lowercase
    @grahamc
    grahamc authored Sep 19, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f2a893c View commit details
Showing with 2 additions and 2 deletions.
  1. +1 −1 ofborg/src/maintainers.nix
  2. +1 −1 ofborg/src/maintainers.rs
2 changes: 1 addition & 1 deletion ofborg/src/maintainers.nix
View file
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ let
(builtins.map
(pkg:
builtins.map (maintainer: {
handle = maintainer.github;
handle = pkgs.lib.toLower maintainer.github;
packageName = pkg.name;
dueToFiles = pkg.filenames;
})
2 changes: 1 addition & 1 deletion ofborg/src/maintainers.rs
View file
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ pub struct MaintainersByPackage(pub HashMap<Package, HashSet<Maintainer>>);
pub struct Maintainer(String);
impl<'a> From<&'a str> for Maintainer {
fn from(name: &'a str) -> Maintainer {
Maintainer(name.to_owned())
Maintainer(name.to_ascii_lowercase().to_owned())
}
}
#[derive(Deserialize, Clone, Debug, Eq, PartialEq, Hash)]