New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
haskell-hakyll: remove outdated patch. #69095
Conversation
@erictapen Could you remove See this explanation on how to to this: https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968 I've confirmed that |
This reverts commit fe366d4.
9de4a3e
to
0cc4d43
Compare
Ah right, forgot about that one. I removed the entry! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erictapen Thanks for putting this PR together!
Everything looks good to me.
@peti This should be ready to be merged in.
i have a somewhat tangential question about this PR, feel free to ignore. if i'm on the |
Here's a script that you can use with with (import <nixpkgs> {});
let
haskellPackagesWithHakyll =
haskellPackages.override {
overrides = hself: hsuper: {
hakyll =
haskell.lib.markUnbroken
( if stdenv.isDarwin
then
haskell.lib.dontCheck (haskell.lib.overrideCabal hsuper.hakyll (drv: {
testToolDepends = [];
}))
else hsuper.hakyll
);
};
};
in
haskellPackagesWithHakyll.hakyll Although you'll have to adapt this slightly for use in |
@mjhoy The way I do it is to not use the channel but:
If you want to update, you can rebase the branch ontop of That way you have one easy way to use arbitrary edits to Nixpkgs, that haven't made it into |
@cdepillabout thanks! i did not know about
@erictapen cool, for whatever reason i couldn't find this commit, maybe commits from |
This is the last issue blocking the
hakyll
build atm.See also #68990
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @