Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpie: add missing 'setuptools' to propagatedBuildInputs #69094

Merged
merged 1 commit into from Sep 20, 2019

Conversation

madjar
Copy link
Member

@madjar madjar commented Sep 19, 2019

As a side-effect of f7e28bf, the build no longer propagated 'setuptools', which
is a run-time dependency. See #68314 for further details.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

As a side-effect of f7e28bf, the build no longer propagated 'setuptools', which
is a run-time dependency. See NixOS#68314 for further details.
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69094
2 package were build:
http-prompt httpie

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 20, 2019
@Ma27 Ma27 merged commit d50d581 into NixOS:master Sep 20, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 20, 2019

Thanks! Backported as e81404f.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants