New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildkite-agent-metrics: init at 5.1.0 #69074
Conversation
bd14910
to
4cbe057
Compare
description = "A command-line tool (and Lambda) for collecting Buildkite agent metrics"; | ||
homepage = "https://github.com/buildkite/buildkite-agent-metrics"; | ||
license = licenses.mit; | ||
maintainers = with maintainers; [ ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you not willing to be a maintainer for this software? there is a push to try and reduce the number of unmaintained packages in nixpkgs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @alexarice, thanks for the reviews.
I am happy to be maintainer but ofBorg failed when I put my name in it, so a second commit removed my name so I could see the tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you got an entry in maintainers.nix
?
@craigem your PR should have eventually two commits:
As for the CI error, just make sure you don't put a typo in that |
I marked this as stale due to inactivity. → More info |
Going to close this PR because @craigem did not react in the last months. |
-X ${t}.Version=${version} | ||
-X ${t}.Revision=unknown | ||
-X ${t}.Branch=unknown | ||
-X ${t}.BuildUser=nix@nixpkgs | ||
-X ${t}.BuildDate=unknown | ||
-X ${t}.GoVersion=${lib.getVersion go} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does a multi-line string actually work for this field?
Motivation for this change
A command-line tool for collecting Buildkite agent metrics, focusing on enabling auto-scaling.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
None yet.