Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offlineimap: 7.2.4 -> 7.3.0 #69202

Merged
merged 1 commit into from
Oct 20, 2019
Merged

offlineimap: 7.2.4 -> 7.3.0 #69202

merged 1 commit into from
Oct 20, 2019
+4 −4

Conversation

endocrimes
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

offlineimap was unmaintained but I'm a pretty heavy user of it so I'm ok
with taking that over for a while.

Sorry, something went wrong.

@endocrimes
offlineimap: 7.2.4 -> 7.3.0

Verified

This commit was signed with the committer’s verified signature.
ejose19
GPG key ID: 09BEDF7CC137762C
Verified
Learn about vigilant mode
de04826
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Sep 21, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 21, 2019

I'm getting the following error with 7.3.0 when trying to sync my email (and it works perfectly fine on master (87a9e5e) with offlineimap 7.2.4):

*** Processing account main
 Establishing connection to mail.mbosch.me:993 (main-remote)
 ERROR: While attempting to sync account 'main'
  [Errno 107] Transport endpoint is not connected
 *** Finished account 'main' in 0:00

Unfortunately I'm not too familiar with offlineimap internals, but do you know what's the issue here? (I can take a look at this as well, but this may take some time :))

Oh and btw, feel free to add me (maintainers.ma27) to the maintainer's list as well, I'm probably not too familiar with the codebase (yet), but I use it quite heavily as well and I'm also interested in helping out as well :)

@endocrimes
Copy link
Member Author

Interesting... locally everything seems to work as expected when using python 2.x:

 [offlineimap(u-offlineimap-7-3-0)] $ NIX_PATH="nixpkgs=/home/danielle/dev/src/github.com/nixos/nixpkgs" nix-shell -p offlineimap
these paths will be fetched (1.51 MiB download, 8.27 MiB unpacked):
  /nix/store/jpmqrdn1jsghfhf6pndfq0mk17654d57-bash-interactive-4.4-p23-info
  /nix/store/lqg80z4wdkkwszkw6cwmazywvk9kvzvd-bash-interactive-4.4-p23-doc
  /nix/store/r9y9gg5lbsdgaxmhp6idl0k556l0x9hs-readline-7.0p5
  /nix/store/s9l4454hlkrbj5fd5yv1dr9xz1daqswj-bash-interactive-4.4-p23
  /nix/store/v4a4366hrmrwhg55fbq6fz39qvww56qg-bash-interactive-4.4-p23-man
  /nix/store/w4bin8lakab76zmcvixql3x77w7329zs-bash-interactive-4.4-p23-dev
copying path '/nix/store/lqg80z4wdkkwszkw6cwmazywvk9kvzvd-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/jpmqrdn1jsghfhf6pndfq0mk17654d57-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/v4a4366hrmrwhg55fbq6fz39qvww56qg-bash-interactive-4.4-p23-man' from 'https://cache.nixos.org'...
copying path '/nix/store/r9y9gg5lbsdgaxmhp6idl0k556l0x9hs-readline-7.0p5' from 'https://cache.nixos.org'...
copying path '/nix/store/s9l4454hlkrbj5fd5yv1dr9xz1daqswj-bash-interactive-4.4-p23' from 'https://cache.nixos.org'...
copying path '/nix/store/w4bin8lakab76zmcvixql3x77w7329zs-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

[nix-shell:~/dev/src/github.com/nixos/nixpkgs/pkgs/tools/networking/offlineimap]$ offlineimap
OfflineIMAP 7.3.0
  Licensed under the GNU GPL v2 or any later version (with an OpenSSL exception)
imaplib2 v2.101 (bundled), Python v2.7.16, OpenSSL 1.1.1c  28 May 2019
Account sync personal:
 *** Processing account personal
 Establishing connection to imap.fastmail.com:993 (tomlinson.io-remote)
Folder devnull [acc: personal]:
 Syncing devnull: IMAP -> Maildir
Folder Drafts [acc: personal]:

That looks like it's coming from python's socket lib tho... maybe weird firewall configuration issues introduced by their extraction of the rfc lib?

@Ma27
Copy link
Member

Ma27 commented Sep 21, 2019

Thanks a lot for the hint! I'll do my best to take a closer look at this tomorrow :)

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2019

Also try to connect with openssl:

$ openssl s_client -servername mail.mbosch.me -connect mail.mbosch.me:993
...
read R BLOCK
* OK [CAPABILITY IMAP4rev1 SASL-IR LOGIN-REFERRALS ID ENABLE IDLE LITERAL+ AUTH=PLAIN AUTH=LOGIN] Dovecot ready.

Ma27
Ma27 approved these changes Oct 20, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like it's coming from python's socket lib tho... maybe weird firewall configuration issues introduced by their extraction of the rfc lib?

Ok, so this was indeed related to some config issues on my side. Sorry for the delay!

@Ma27 Ma27 merged commit 8ac510b into NixOS:master Oct 20, 2019
@endocrimes endocrimes deleted the u-offlineimap-7-3-0 branch October 20, 2019 12:56
@endocrimes
Copy link
Member Author

@Ma27 no worries - thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@endocrimes @Ma27 @Mic92