New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
palemoon: 28.7.0 -> 28.7.1 #69206
palemoon: 28.7.0 -> 28.7.1 #69206
Conversation
Building Pale Moon seems to fail sometimes/always, depending on to me unknown factors. It builds fine in my NixOS VM, but my NixOS desktop consistently fails with
it's possible this also caused this build here to fail? This also happened to me before this update, so it's not a blocker for it, but it's definitely not good either... |
Looking at
it checks for the existence of a dbus session bus to provide a notification. |
You mean the dbus dependencies? I'll check if that's the only thing they're required for and remove them if that's the case. try:
import dbus
except ImportError:
raise Exception('Install the python dbus module to '
'get a notification when the build finishes.')
I know bugger-all about Python or the mach build system, so I don't feel comfortable meddling with that and patching out stuff, but I think i found a flag to disable just the notification stuff. I'll submit it once I've tested locally that it works properly. |
The notifications within the program or at build time? If you aren't able to work it out I could write a patch for you. |
The "Notification center" is for build-time notifications. (I think) moz_nospam = os.environ.get('MOZ_NOSPAM')
if moz_nospam:
return I'm running a test build right now with that variable set. If it works, it should be enough right? |
Yep, appears to just return if that variable is in the environment. |
Documentation for building Pale Moon 28 says that GCC7 is "strongly recommended".
Envvar MOZ_NOSPAM should stop attempts to do build notifications.
Added the MOZ_NOSPAM variable and pinned the used GCC version to 7.* according to this recommendation I found. |
@GrahamcOfBorg eval |
Changes as requested in NixOS#69206
Changes as requested in NixOS#69206 (cherry picked from commit f7bd174)
Motivation for this change
Security and bugfix update to Pale Moon. From the release notes:
Should prolly be backported to
release-19.09
as well.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)