Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitea: fix dump #69201

Merged
merged 1 commit into from Sep 21, 2019
Merged

nixos/gitea: fix dump #69201

merged 1 commit into from Sep 21, 2019

Conversation

c0deaddict
Copy link
Member

(cherry picked from commit 86b83f3)

Motivation for this change

see #69195

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @etu

@c0deaddict
Copy link
Member Author

Not sure why it says "(cherry picked from commit 86b83f3)" at the top, since this one couldn't be cherry picked.

@etu
Copy link
Contributor

etu commented Sep 21, 2019

@c0deaddict That's on purpose, that's what -x does :)

Because it becomes a new commit hash on another head, and then it's nice to have that reference to the original commit.

@etu etu merged commit fdf5764 into NixOS:release-19.03 Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0deaddict @etu