Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgdiplus: split package to reduce dependencies closure size #69147

Merged
merged 1 commit into from Sep 22, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Sep 20, 2019

Motivation for this change

nix path-info -rSh on mono:

Before: /nix/store/p7zix8ypkqdwz86jvirzn0hmqhkbfhf7-mono-5.20.1.27 1.2G
After: /nix/store/zwg8d5m2d7hbi1ylh6rq00wyghyyzpsp-mono-5.20.1.27 881.3M

Mostly due to not dragging in cairo-dev, mesa-dev, etc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nix path-info -rSh on mono:

Before: /nix/store/p7zix8ypkqdwz86jvirzn0hmqhkbfhf7-mono-5.20.1.27                 1.2G
After:  /nix/store/zwg8d5m2d7hbi1ylh6rq00wyghyyzpsp-mono-5.20.1.27               881.3M

Mostly due to not dragging in cairo-dev, mesa-dev, etc.
@delroth
Copy link
Contributor Author

delroth commented Sep 20, 2019

Relevant bug: #69146

@delroth delroth force-pushed the mono-closure-size branch 2 times, most recently from c61e717 to dd5eb4d Compare September 22, 2019 11:43
@Mic92 Mic92 merged commit 382308c into NixOS:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants