Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-pi: add midi support #69199

Merged

Conversation

c0deaddict
Copy link
Member

@c0deaddict c0deaddict commented Sep 21, 2019

Motivation for this change

This PR adds MIDI support to Sonic PI through the use of the osmid dependency. By using osmid Sonic Pi finds attached MIDI devices and shows them in the interface (see https://sonic-pi.net/tutorial.html#section-11). Tested with a https://www.akaipro.com/kb/akai-pro-midimix-setup-with-logic-pro-x/

Also pinned the ruby version to ruby_2_4 as the package fails to build with the latest ruby. This should fix #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0deaddict c0deaddict force-pushed the feature/sonic-pi-add-midi-support branch from fe677c3 to 46b23c8 Compare October 4, 2019 13:46
@c0deaddict
Copy link
Member Author

Thanks for your review @Phlogistique

@ofborg ofborg bot requested a review from Phlogistique October 4, 2019 13:59
@c0deaddict c0deaddict force-pushed the feature/sonic-pi-add-midi-support branch from 46b23c8 to 2a79578 Compare October 11, 2019 13:58
@c0deaddict
Copy link
Member Author

@Phlogistique can this PR be merged?

@Phlogistique
Copy link
Contributor

I do not have commit rights so I can not merge it.

@matthewbauer matthewbauer merged commit e78dd20 into NixOS:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero Hydra Failures: 19.09 edition
3 participants