function-trace: always show the trace #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
force-pushed
the
show-traces
branch
from
1efe134
to
403d703
Compare
zimbatm
force-pushed
the
show-traces
branch
from
403d703
to
3285bbf
Compare
edolstra
reviewed
Sep 18, 2019
src/libexpr/function-trace.hh
Outdated
|
|
||
| FunctionCallTrace(const Pos & pos) : pos(pos) { | ||
| FunctionCallTrace(const string type, const Pos & pos) { |
There was a problem hiding this comment.
This should be const string & type.
There was a problem hiding this comment.
oops, that was part of an ongoing experiment where I try to qualify the traces a bit better when the pos is undefined (like all the primop calls). Removed it from this PR for now.
If the user invokes nix with --trace-function-calls it means that they want to see the trace.
zimbatm
force-pushed
the
show-traces
branch
from
3285bbf
to
619cc4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user invokes nix with --trace-function-calls it means that they
want to see the trace. This removes the need to also add
-vvvvto the command.