Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libuv: 1.30.1 -> 1.32.0 #68748

Merged
merged 1 commit into from Sep 18, 2019
Merged

libuv: 1.30.1 -> 1.32.0 #68748

merged 1 commit into from Sep 18, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 14, 2019

Motivation for this change

https://github.com/libuv/libuv/releases/tag/v1.32.0
https://github.com/libuv/libuv/releases/tag/v1.31.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cstrahan September 14, 2019 04:11
@disassembler
Copy link
Member

@GrahamcOfBorg build libuv

@vcunat
Copy link
Member

vcunat commented Sep 14, 2019

The command didn't work? I can't really test darwin.
@GrahamcOfBorg build libuv

@vcunat
Copy link
Member

vcunat commented Sep 15, 2019

@grahamc: do you know if that's intentional, off the top of your head? (Say, because staging PRs usually have a hard time to finish. I found no mention of "staging" in the repo.)

marsam
marsam approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on Darwin and NixOS

@marsam marsam mentioned this pull request Sep 18, 2019
Merged
10 tasks
vcunat added a commit that referenced this pull request Sep 18, 2019
@vcunat
Merge #68748: libuv: 1.30.1 -> 1.32.0 (into staging)
b7089e7
@vcunat vcunat merged commit f0b8024 into NixOS:staging Sep 18, 2019
@marsam marsam mentioned this pull request Oct 26, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @disassembler @vcunat @marsam