Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meli: init at pre-alpha-0.3.2 #69169

Closed
wants to merge 2 commits into from
Closed

meli: init at pre-alpha-0.3.2 #69169

wants to merge 2 commits into from

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Sep 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

alexarice
alexarice approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs with nix-review on nixos

pkgs/applications/networking/mailreaders/meli/default.nix Outdated Show resolved Hide resolved
@alexarice
Copy link
Contributor

Did you mean to request me to review this?

@alexarice
Copy link
Contributor

@GrahamcOfBorg build meli

alexarice
alexarice reviewed Sep 24, 2019
View reviewed changes
Copy link
Contributor

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to build on aarch so maybe platforms should be changed

@0x4A6F 0x4A6F changed the title meli: init at pre-alpha-0.3.0 meli: init at pre-alpha-0.3.2 Sep 29, 2019
@0x4A6F
Copy link
Member Author

0x4A6F commented Sep 29, 2019

@alexarice Should now build and run on aarch64.

@alexarice
Copy link
Contributor

@GrahamcOfBorg build meli

@aanderse
Copy link
Member

@alexarice did you test the program locally?

@alexarice
Copy link
Contributor

I think so but I'll do it again now

@alexarice
Copy link
Contributor

Build fails with:

fatal: reference is not a tree: 7c2c8ae9453c81c026dde845aff5934a1df0de80
  Unable to checkout 7c2c8ae9453c81c026dde845aff5934a1df0de80 from https://git.meli.delivery/meli/meli.git.

@matthiasbeyer
Copy link
Contributor

matthiasbeyer commented Oct 13, 2019 •
edited

@0x4A6F please ff-pull from https://github.com/matthiasbeyer/nixpkgs/tree/master-meli - I fixed the hashes for the derivation.

Though, my build still fails, with:

these derivations will be built:
  /nix/store/h3chyx3vlf0icdxlpfhl1wa33wh91kg2-meli-pre-alpha-0.3.2.drv
building '/nix/store/h3chyx3vlf0icdxlpfhl1wa33wh91kg2-meli-pre-alpha-0.3.2.drv'...
unpacking sources
unpacking source archive /nix/store/gwcb2gsq1c5lfyfm7pdkcnldddgw77qn-meli-b7edec0
source root is meli-b7edec0
unpacking source archive /nix/store/fvxz7kh6z9jk40cq47rpap7dfnv0x1iy-meli-pre-alpha-0.3.2-vendor
patching sources
configuring
building
++ env CC_x86_64-unknown-linux-gnu=/nix/store/7hzmz83nv8khpwsk858yaac7y3idh0a7-gcc-wrapper-8.3.0/bin/cc CXX_x86_64-unknown-linux-gnu=/nix/store/7hzmz83nv8khpwsk858yaac7y3idh0a7-gcc-wrapper-8.3.0/bin/c++ CC_x86_64-unknown-linux-gnu=/nix/store/7hzmz83nv8khpwsk858yaac7y3idh0a7-gcc-wrapper-8.3.0/bin/cc CXX_x86_64-unknown-linux-gnu=/nix/store/7hzmz83nv8khpwsk858yaac7y3idh0a7-gcc-wrapper-8.3.0/bin/c++ cargo build --release --target x86_64-unknown-linux-gnu --frozen
error: the lock file /build/meli-b7edec0/Cargo.lock needs to be updated but --frozen was passed to prevent this
builder for '/nix/store/h3chyx3vlf0icdxlpfhl1wa33wh91kg2-meli-pre-alpha-0.3.2.drv' failed with exit code 101
error: build of '/nix/store/h3chyx3vlf0icdxlpfhl1wa33wh91kg2-meli-pre-alpha-0.3.2.drv' failed

@0x4A6F
Copy link
Member Author

0x4A6F commented Oct 14, 2019

The source branch aarch64 vanished.
So I rebased the commit "meli: fix for aarch64" to meli/51bb50abf3

@matthiasbeyer Your commit is similar to "meli: init at pre-alpha-0.3.2", sans cargoPatches.

We might wait for the next release and thus get rid of cargoPatches and have aarch64 support?

@erictapen erictapen mentioned this pull request Dec 26, 2019
Merged
10 tasks
@0x4A6F
Copy link
Member Author

0x4A6F commented May 4, 2020

Closing in favor of #76519.

@0x4A6F 0x4A6F closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@alexarice alexarice alexarice approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0x4A6F @alexarice @aanderse @matthiasbeyer