Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add hardware.enableAllUdevRules #69168

Closed
wants to merge 8 commits into from

Conversation

matthewbauer
Copy link
Member

This is similar to enableAllFirmware, but for udev rules. Basically, try to put in all of the udev rules we know of, without adding any extra dependencies. This unifies a lot of modules and should make maintenence easier in the future.

Also remove some -udev-rules "packages" that aren't really packages.

Perhaps we should merge these into one rules directory and publish it as "nixos-udev-rules" or something like that?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

These aren’t really package and instead should be moved to their
respective nixos module.
This can be used to enable all of the udev-rules modules we provide.
Makes it easier when you aren’t sure what hardware you will be having.
Should all be simple text files with no extra dependencies.
These options can now be merged into one big udev rules module.
These are not necessarily useful to everyone. Better to leave them as
is.
@infinisil
Copy link
Member

It's a bit weird, but I guess udev rules really don't cost much to install (right?), so this is probably fine. I also like how this removes those trivial udev modules.

@bjornfor
Copy link
Contributor

bjornfor commented Oct 6, 2019

I read the option as "add all environment.systemPackages to services.udev.packages" :-)

@matthewbauer matthewbauer changed the title Add hardware.enableAllUdevRules [WIP] Add hardware.enableAllUdevRules Oct 6, 2019
@matthewbauer
Copy link
Member Author

I read the option as "add all environment.systemPackages to services.udev.packages" :-)

Yeah that's definitely a bit confusing. Some other name might be better. "enableExtraUdevRules" or something similar.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants