[19.03] broadcom_sta: fix build on linux-5.1 #69167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
changed the title
10 tasks
veprbl
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
Passes nix-review on x86_64-linux:
2 package are marked as broken and were skipped:
linuxPackages_hardkernel_4_14.broadcom_sta linuxPackages_hardkernel_latest.broadcom_sta
1 package failed to build:
linuxPackages-libre.broadcom_sta
13 package were build:
linuxPackages.broadcom_sta linuxPackages_4_14.broadcom_sta linuxPackages_4_4.broadcom_sta linuxPackages_4_9.broadcom_sta linuxPackages_5_1.broadcom_sta linuxPackages_5_2.broadcom_sta linuxPackages_hardened.broadcom_sta linuxPackages_latest-libre.broadcom_sta linuxPackages_latest_hardened.broadcom_sta linuxPackages_latest_xen_dom0.broadcom_sta linuxPackages_testing_bcachefs.broadcom_sta linuxPackages_testing_hardened.broadcom_sta linuxPackages_xen_dom0.broadcom_sta
|
@werner291 Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I tried to install kernel 5.2 onto my NixOS 19.03 machine to get my Ryzen 3400G's integrated GPU to work, but this failed due to incompatibilities with the broadcom-sta package.
This should fix #68656
Things done
Cherry-picked 75a60db onto release-19.03
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @