Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hedgewars: 1.0.0-beta1 -> 1.0.0-beta2 #69097

Merged
merged 1 commit into from Sep 24, 2019
Merged

hedgewars: 1.0.0-beta1 -> 1.0.0-beta2 #69097

merged 1 commit into from Sep 24, 2019

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Sep 19, 2019 •
edited

Motivation for this change

Move from qt4 to qt5. It was already using qt5, sorry.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

@peterhoeg peterhoeg merged commit 91d7486 into NixOS:master Sep 24, 2019
@peterhoeg peterhoeg deleted the u/hedgewars branch September 26, 2019 13:42
@peterhoeg peterhoeg restored the u/hedgewars branch September 27, 2019 00:57
@alexarice
Copy link
Contributor

@peterhoeg @NixOS/backports should this be backported to 19.09 as this also fixes qt problems?

@worldofpeace
Copy link
Contributor

@peterhoeg @NixOS/backports should this be backported to 19.09 as this also fixes qt problems?

Yes, I've been taking special measure to check wherever qt problems are fixed to make backports.
Though this included an update, it's beta software anyway.

@alexarice
Copy link
Contributor

@worldofpeace did you want me to create a PR?

@worldofpeace
Copy link
Contributor

@alexarice I'm testing it right now, should be pushed shortly 👍

@alexarice
Copy link
Contributor

Ping me if you want me to run it locally as well

@worldofpeace
Copy link
Contributor

backported in 419abba.

@peterhoeg peterhoeg deleted the u/hedgewars branch October 21, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @alexarice @worldofpeace