Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-tools: 1.15.0 -> 1.16.1 #69098

Merged
merged 1 commit into from Nov 19, 2019
Merged

cri-tools: 1.15.0 -> 1.16.1 #69098

merged 1 commit into from Nov 19, 2019

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Sep 19, 2019 •
edited

Motivation for this change

Update cri-tools to the latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

None

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build cri-tools

@saschagrunert
cri-tools: 1.15.0 -> 1.16.1
10fe9b1 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title cri-tools: 1.15.0 -> 1.16.0 cri-tools: 1.15.0 -> 1.16.1 Oct 2, 2019
@saschagrunert
Copy link
Member Author

Update to 1.16.1

@saschagrunert saschagrunert mentioned this pull request Oct 15, 2019
Merged
10 tasks
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 17, 2019 •
edited

@srhb do you think we can merge this update as well for k8s 1.16?

@srhb
Copy link
Contributor

srhb commented Nov 17, 2019

@saschagrunert Absolutely! I'll give it a quick spin.

@srhb
Copy link
Contributor

srhb commented Nov 17, 2019

Basic functionality looks good. I haven't tested actually talking to a CRI server. This might be nice to have in a test somewhere, at some point. :)

@srhb
Copy link
Contributor

srhb commented Nov 17, 2019

Looking at the diff, is there any reason to not have make install BINDIR[...] in the installPhase?

@saschagrunert
Copy link
Member Author

Looking at the diff, is there any reason to not have make install BINDIR[...] in the installPhase?

Hm no I think this is actually needed to install it not into the $GOPATH/bin

@srhb srhb merged commit 6a0486b into NixOS:master Nov 19, 2019
@saschagrunert saschagrunert deleted the cri-tools branch November 19, 2019 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @srhb