Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapQtAppsHook: correct skip directories heuristic #69173

Merged
merged 1 commit into from Sep 21, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Fixes #69171 but still should achieve what e55db07 wanted to do.
I've built zoom-us and it's wrapped.

Note that e55db07 is on 19.09. We could either revert it there or backport this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor Author

Something like bbb2f93 would be a better improvement. But I want to fix master and stable quickly.

@bjornfor
Copy link
Contributor

+1 for reverting e55db07 on release-19.09 then. Sorry for introducing a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrapQtAppsHook stopped wrapping symlinks
3 participants