Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.typed-ast: 1.3.5 -> 1.4.0, pythonPackages.mypy: 0.701 -> 0.711 #69178

Merged
merged 2 commits into from Sep 21, 2019

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Sep 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@uri-canva
Copy link
Contributor Author

This is a bit hard to test because so many packages that depend on them are already failing on master.

These need to be updated together.

@ofborg ofborg bot requested review from LnL7 and martingms September 21, 2019 00:45
@Mic92 Mic92 merged commit 495f0ea into NixOS:master Sep 21, 2019
@uri-canva uri-canva deleted the typed-ast branch September 21, 2019 10:37
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 22, 2019
pythonPackages.typed-ast: 1.3.5 -> 1.4.0,  pythonPackages.mypy: 0.701 -> 0.711

(cherry picked from commit 495f0ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants