Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ppx_deriving_yojson: 3.3 -> 3.5.1 #69089

Merged
merged 1 commit into from Sep 19, 2019
Merged

ocamlPackages.ppx_deriving_yojson: 3.3 -> 3.5.1 #69089

merged 1 commit into from Sep 19, 2019

Conversation

maximedenes
Copy link
Contributor

Update of ocamlPackages.ppx_deriving_json (makes it compatible with OCaml 4.08).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @vbgl

@vbgl
Copy link
Contributor

vbgl commented Sep 19, 2019

@GrahamcOfBorg build fstar pyre

@vbgl vbgl merged commit 4e626be into NixOS:master Sep 19, 2019
@maximedenes
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maximedenes @vbgl