Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 3.8.0 -> 3.9.0 #69075

Merged
merged 1 commit into from Sep 19, 2019
Merged

radare2: 3.8.0 -> 3.9.0 #69075

merged 1 commit into from Sep 19, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 19, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
Copy link
Member Author

Mic92 commented Sep 19, 2019

@GrahamcOfBorg build radare2

@Mic92 Mic92 merged commit 3715f06 into NixOS:master Sep 19, 2019
@Mic92 Mic92 deleted the radare2 branch September 19, 2019 04:00
@ofborg ofborg bot requested review from makefu and 7c6f434c September 19, 2019 04:11
@makefu
Copy link
Contributor

makefu commented Sep 19, 2019

so fast, so furious 🏎️ 💨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makefu makefu Awaiting requested review from makefu

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @makefu